peachisai commented on code in PR #11954:
URL: https://github.com/apache/skywalking/pull/11954#discussion_r1507092996
##########
docs/en/concepts-and-designs/service-hierarchy.md:
##########
@@ -162,6 +164,22 @@ If you want to customize it according to your own needs,
please refer to [Servic
- VIRTUAL_MQ.service.name:
`rabbitmq.skywalking-showcase.svc.cluster.local:5672`
- RABBITMQ.service.name: `rabbitmq::rabbitmq.skywalking-showcase`
+#### KAFKA On K8S_SERVICE
+- Rule name: `short-name`
+- Groovy script: `{ (u, l) -> u.shortName == l.shortName }`
+- Description: KAFKA.service.shortName == K8S_SERVICE.service.shortName
+- Matched Example:
+ - ROCKETMQ.service.name: `kafka::kafka.skywalking-showcase`
+ - K8S_SERVICE.service.name: `skywalking-showcase::kafka.skywalking-showcase`
+
+#### VIRTUAL_MQ On KAFKA
+- Rule name: `lower-short-name-with-fqdn`
+- Groovy script: `{ (u, l) -> u.shortName.substring(0,
u.shortName.lastIndexOf(':')) == l.shortName.concat('.svc.cluster.local') }`
+- Description: VIRTUAL_MQ.service.shortName remove port ==
KAFKA.service.shortName with fqdn suffix
+- Matched Example:
+ - VIRTUAL_MQ.service.name: `kafka.skywalking-showcase.svc.cluster.local:9092`
Review Comment:
> The case is, when Kafka is set, you may use Kafka broker addresses, and
the app client is using data node addresses to communicate. Those address may
not match the one from otel monitoring and k8s part.
May be I am not very follow your meaning , for end users, they should use
the same address or customize script, for showcase, we could change the otel
label output, Is that so?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
