sivasathyaseeelan opened a new pull request, #395:
URL: https://github.com/apache/skywalking-banyandb/pull/395

   
   ### Fix
   - [ ] Add a unit test to verify that the fix works.
   - [x] Explain briefly why the bug exists and how to fix it.
   
   
   ### Feature description
   
   This is a PR which improves the UI of Not found View. In this PR i have 
deleted `NotFoundView.vue` and creates a `404` folder in `./ui/src/views`, this 
`404` folder contain `NotFound.vue` which is the improved UI of  Not found 
View. And I have also changed index.js file in `./ui/src/router` to show the 
newly created `NotFound.vue` with `Header/Navbar`.
   
   #### Relevant Images/Videos
   ![404 Page Not 
Found](https://github.com/apache/skywalking-banyandb/assets/95441117/9ac499bf-39c7-4922-8f95-dc38430fd3a5)
   
   [404 Page Not 
Found](https://github.com/apache/skywalking-banyandb/assets/95441117/84999e48-c92d-4166-ac8c-a91b490a371f)
   
   
   - [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
   - [ ] Update the documentation to include this new feature.
   - [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
   - [x] If it's UI related, attach the screenshots below.
   
   - [x] If this pull request closes/resolves/fixes an existing issue, replace 
the issue number. Fixes https://github.com/apache/skywalking/issues/11964 .
   - [ ] Update the [`CHANGES` 
log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to