hanahmily commented on code in PR #395: URL: https://github.com/apache/skywalking-banyandb/pull/395#discussion_r1511836757
########## ui/src/assets/banyan-db.svg: ########## Review Comment: Rename this file to "banyandb.svg" ########## ui/src/views/404/NotFound.vue: ########## Review Comment: Could you explain why you moved the page to a subfolder when the filename "NotFoundView" already indicates it's used as a 404 page? ########## ui/src/assets/banyan-db.svg: ########## Review Comment: You need to add a license header to this file in order to pass the CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
