sksDonni opened a new pull request, #396:
URL: https://github.com/apache/skywalking-banyandb/pull/396

   
   ### Fix [banyandb web-ui console error 
logs](https://github.com/apache/skywalking/issues/11273)
   Experiencing exception logs in the console of the banyandb dashboard when we 
switch between two read tabs. 
   
   - [ ] Add a unit test to verify that the fix works.
   
   - [X] Explain briefly why the bug exists and how to fix it.
   The issue was caused due to the use of `JSON.parse(JSON.stringify())` to 
clone the route object. This method of cloning objects cannot handle circular 
references, leading to an exception in the console.
   
   - [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
   - [ ] Update the documentation to include this new feature.
   - [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
   - [X] If it's UI related, attach the screenshots below.
   
   
https://github.com/apache/skywalking-banyandb/assets/53624363/b62bba6e-2678-4e8a-9b3e-4436cd0f5649
   
   - [X] If this pull request closes/resolves/fixes an existing issue, replace 
the issue number. Fixes apache/skywalking#11273.
   - [ ] Update the [`CHANGES` 
log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to