wfxSuchith commented on code in PR #396:
URL:
https://github.com/apache/skywalking-banyandb/pull/396#discussion_r1512176516
##########
ui/src/components/Read/index.vue:
##########
@@ -184,8 +184,10 @@ watch(() => data.code, () => {
if (index >= 0) {
data.codeStorage[index].params.code = data.code
} else {
+
route.params.code = data.code
- data.codeStorage.push(JSON.parse(JSON.stringify(route)))
+ const clonedObject = Object.assign({}, route);
Review Comment:
sure @hanahmily and @Fine0830, will look into this and update the PR
accordingly.
##########
ui/src/components/Read/index.vue:
##########
@@ -184,8 +184,10 @@ watch(() => data.code, () => {
if (index >= 0) {
data.codeStorage[index].params.code = data.code
} else {
+
route.params.code = data.code
- data.codeStorage.push(JSON.parse(JSON.stringify(route)))
+ const clonedObject = Object.assign({}, route);
Review Comment:
sure @hanahmily and @Fine0830, will look into this and update the PR
accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
