wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107534947
> > I think you got it wrong. It should be in ContextManager#continued method, which controls the context. > > Understood. How can the [span](https://github.com/apache/skywalking-java/blob/1a010470076ba7f206f4fd6559d04136bea73417/apm-sniffer/optional-plugins/optional-spring-plugins/optional-spring-cloud/gateway-2.0.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/cloud/gateway/v20x/NettyRoutingFilterInterceptor.java#L44) used by the plugin be changed to a NoopSpan? Consider creating `AbstractTracerContext#forceIgnoring. `TracingContext#forceIgnoring` could return a `IgnoredTracerContext` with the same stack depth, to make sure no tracing context stack leak. `IgnoredTracerContext` just simply returns **this** as no change is required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
