wu-sheng commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1601087830


##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java:
##########
@@ -34,14 +34,21 @@ public class IgnoredTracerContext implements 
AbstractTracerContext {
     private static final NoopSpan NOOP_SPAN = new NoopSpan();
     private static final String IGNORE_TRACE = "Ignored_Trace";
 
+    private LinkedList<AbstractSpan> activeSpanStack;

Review Comment:
   Another option maybe to create a ForceIgnoreTracerContext to deal with 
created span cases. 
   And this only happens in very rare case, so we should process that only when 
we checked all active spans, which have one running in async mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to