youjie23 commented on PR #13539: URL: https://github.com/apache/skywalking/pull/13539#issuecomment-3521153182
> Let's add the different cases in the UT and check if the alarm window status changes as expected: > > 1. `silencePeriod` and `recoveryObservationPeriod` are not set. > 2. Only set `silencePeriod`. > 3. Only set `recoveryObservationPeriod`. > 4. `silencePeriod` > `recoveryObservationPeriod`. > 5. `recoveryObservationPeriod` > `silencePeriod`. > > The status changes should include the `AlarmStateMachine` current status after each `match` or `misMatch` I have added the unit tests to cover all the different cases you mentioned. The tests now verify the status changes of the AlarmStateMachineafter each match and misMatch. The changes are in RunningRuleTest. Please review when you have time. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
