kezhenxu94 commented on code in PR #13539: URL: https://github.com/apache/skywalking/pull/13539#discussion_r2525386350
########## test/e2e-v2/cases/apisix/otel-collector/e2e.yaml: ########## @@ -31,7 +31,7 @@ setup: trigger: action: http interval: 3s - times: 10 + times: -1 Review Comment: We need to modify the `times` in all places in this PR, as I suggested https://github.com/apache/skywalking-infra-e2e/pull/134#issuecomment-3436596334 It was a bug that `times` didn’t take effect in e2e, but in this repo, if setting `times` to 10 was intended, which means after 10 times the trigger should stop, then the tests should passed without changes, otherwise, setting times to 10 was wrong and should be updated to -1 like this PR did -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
