weixiang1862 commented on code in PR #13615: URL: https://github.com/apache/skywalking/pull/13615#discussion_r2618210464
########## oap-server/server-starter/src/main/resources/oal/mesh.oal: ########## @@ -16,21 +16,21 @@ * */ -service_sidecar_internal_req_latency_nanos = from(Service.sideCar.internalRequestLatencyNanos).longAvg(); -service_sidecar_internal_resp_latency_nanos = from(Service.sideCar.internalResponseLatencyNanos).longAvg(); +service_sidecar_internal_req_latency_nanos = from(Service.sideCar.internalRequestLatencyNanos).filter(sideCar != null).longAvg(); +service_sidecar_internal_resp_latency_nanos = from(Service.sideCar.internalResponseLatencyNanos).filter(sideCar != null).longAvg(); Review Comment: I think the out-of-the-box state is better: if users don't use mesh, mesh metrics are not generated; if users use mesh, mesh metrics are generated. Changing configuration files may introduce more works for user. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
