wu-sheng commented on code in PR #13615: URL: https://github.com/apache/skywalking/pull/13615#discussion_r2618223191
########## oap-server/server-starter/src/main/resources/oal/mesh.oal: ########## @@ -16,21 +16,21 @@ * */ -service_sidecar_internal_req_latency_nanos = from(Service.sideCar.internalRequestLatencyNanos).longAvg(); -service_sidecar_internal_resp_latency_nanos = from(Service.sideCar.internalResponseLatencyNanos).longAvg(); +service_sidecar_internal_req_latency_nanos = from(Service.sideCar.internalRequestLatencyNanos).filter(sideCar != null).longAvg(); +service_sidecar_internal_resp_latency_nanos = from(Service.sideCar.internalResponseLatencyNanos).filter(sideCar != null).longAvg(); Review Comment: Generally, users are not encouraged to activate all analyses, as, it actually has a price(extra and unnecessary resources) to pay. Please follow this best practice. The extra resource costs(CPU, memory) are much more expensive in the product env, compared with a config to be set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
