onkar717 commented on issue #13620: URL: https://github.com/apache/skywalking/issues/13620#issuecomment-3711818129
Hi @hanahmily, I’m preparing to work on this feature and had a few clarification questions to align with the expected design: Timestamp availability: In the current codebase, secondary index building (sidx) only receives the Key and not the original record timestamp. Would you prefer: extending sidx.WriteRequest to explicitly carry the timestamp, or propagating timestamp metadata alongside keys during part building (without changing the public write API)? Timestamp-as-key case: When the secondary index key itself is a timestamp (e.g. ValueTypeTimestamp), is it acceptable to omit min_timestamp / max_timestamp in manifest.json and rely on MinKey / MaxKey only? Query pruning scope: Should time-range pruning be applied only at part-selection level (before reading blocks), or do you expect any deeper integration (e.g. block-level filtering)? I want to ensure the implementation matches the intended direction before submitting a PR. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
