hanahmily commented on issue #13620: URL: https://github.com/apache/skywalking/issues/13620#issuecomment-3712592429
@onkar717, Thank you for taking on this task. I would like to suggest refactoring the `sidx.WriteRequest` to explicitly include the timestamp. Additionally, I recommend keeping the `min_timestamp` and `max_timestamp` fields in `manifest.json`, even if the keys are the timestamps themselves. This approach will simplify both writing and querying, and simplification often leads to a more robust system. In the querying process, these two fields should be used for part selection and not in the block scope. Furthermore, please ensure these fields are updated after merging the two parts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
