wu-sheng opened a new pull request, #13903:
URL: https://github.com/apache/skywalking/pull/13903

   ### Implement SWIP-15 BanyanDB self-observability around the cluster / 
container / group model
   
   Rebuilds the `otel-rules/banyandb/` self-observability feature to match how 
BanyanDB is actually built and operated (**requires BanyanDB 0.11+**):
   
   - **Entity model**: `Service` = one BanyanDB **cluster** 
(`service(['cluster'])`); `ServiceInstance` = one **container** keyed on 
`pod_name` + `container_name` (with `node_role` / `node_type` / 
`container_name` / `pod_name` as instance attributes); `Endpoint` = one storage 
**group**.
   - **Rules**: new `banyandb-endpoint.yaml`; `banyandb-service.yaml` (7 rules) 
and `banyandb-instance.yaml` (43 rules) redesigned. Source expressions mirror 
the upstream BanyanDB FODC-proxy Grafana boards (`grafana-fodc-nodes.json` / 
`grafana-fodc-workload.json`) so the SkyWalking dashboards stay in lockstep. 
The stale single-node `host_name` model and the removed `etcd_operation_rate` / 
`up`-derived `active_instance` / `queue_sub_total_msg_sent_err` metrics are 
dropped.
   - **Docs**: `docs/en/banyandb/dashboards-banyandb.md` rewritten to the 
cluster/container/group model.
   - **E2E**: rewritten to a no-FODC, file-discovery BanyanDB 0.11 cluster (1 
liaison + 1 hot data node, no etcd). The OTel collector scrapes each node's 
`:2121` directly and injects the FODC-equivalent identity labels as static 
per-scrape-job labels, so the full rule set is exercised without a FODC proxy.
   
   **Validation**
   - `DSLClassGeneratorTest` compiles every rule through the production 
`MetricConvert` path (service 7 + instance 43 + endpoint 11), including the 
6-arg `instance()` properties closure, `histogram_percentile`, `tagNotEqual`, 
and `time()`.
   - The e2e passes **16/16** against the latest BanyanDB 0.11 build, covering 
service / instance / endpoint scopes.
   
   - [x] If this is non-trivial feature, paste the links/URLs to the design 
doc. — [SWIP-15](docs/en/swip/SWIP-15.md).
   - [x] Update the documentation to include this new feature. — 
`docs/en/banyandb/dashboards-banyandb.md`.
   - [x] Tests(including UT, IT, E2E) are added to verify the new feature. — 
rewritten `test/e2e-v2/cases/banyandb/` e2e; rules compile-validated by 
`DSLClassGeneratorTest`.
   - [ ] If it's UI related, attach the screenshots below. — N/A; the BanyanDB 
dashboards ship from the Horizon UI bundle (separate repo).
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace 
the issue number. Closes #<issue number>.
   - [x] Update the [\`CHANGES\` 
log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to