wu-sheng commented on PR #13903:
URL: https://github.com/apache/skywalking/pull/13903#issuecomment-4675857888
Re-checked the `query_latency` comment — it raised two points and my first
push only covered one. Now both are addressed: (1) `safeDiv` guards the
empty/zero denominator, and (2) the ratio is now **windowed** — `rate('PT1M')`
is applied to both `liaison_grpc_total_latency` and `_started` (matching the
upstream Grafana "Query Latency" panel) instead of dividing raw cumulative
counters (which gave an all-time average). `DSLClassGeneratorTest` recompiles
clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
