wu-sheng commented on issue #3726: Improve visibility for DataCarrier. URL: https://github.com/apache/skywalking/pull/3726#issuecomment-553253716 As @yantaowu told me offline, they are using `Queue#offer` with accepting queue is full and data lost tradeoff. The result is not so different, as we don't make the queue full in our tests. **testBuffer2** is using `#offer` method in the test. ``` Benchmark Mode Cnt Score Error Units ChannelWritePerformanceTest.testBuffer1 thrpt 10 29020.969 ± 613.798 ops/s ChannelWritePerformanceTest.testBuffer2 thrpt 10 32102.383 ± 1715.402 ops/s ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
