wu-sheng commented on issue #3726: Improve visibility for DataCarrier. URL: https://github.com/apache/skywalking/pull/3726#issuecomment-553263718 I dig more into the ArrayBlockingQueue source code, I noticed there is a misguide from the user feedback. `ArrayBlockingQueue` didn't ever deal with across thread visibility ever. Everyone here could check the source code. So after I remove the `volatile`, but keep the `BufferItem`. There is no advantage of the BlockingQueue. ``` Benchmark Mode Cnt Score Error Units ChannelWritePerformanceTest.testBuffer1 thrpt 10 45184.551 ± 425.330 ops/s ChannelWritePerformanceTest.testBuffer2 thrpt 10 33548.799 ± 1793.056 ops/s ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
