wu-sheng commented on a change in pull request #4239: [WIP] Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r367179675
########## File path: dist-material/application.yml ########## @@ -135,6 +135,16 @@ storage: # dataSource.prepStmtCacheSqlLimit: ${SW_DATA_SOURCE_PREP_STMT_CACHE_SQL_LIMIT:2048} # dataSource.useServerPrepStmts: ${SW_DATA_SOURCE_USE_SERVER_PREP_STMTS:true} # metadataQueryMaxSize: ${SW_STORAGE_MYSQL_QUERY_MAX_SIZE:5000} + influx: + myDriver: ${SW_STORAGE_MY_DRIVER:org.h2.jdbcx.JdbcDataSource} Review comment: You should support to set metadata DB type. Otherwise, you have to link to single one DB implementation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services