wu-sheng commented on a change in pull request #4239: [WIP] Provide influxdb as
a new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r368257153
##########
File path:
oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/influxdb/base/InfluxStorageDAO.java
##########
@@ -53,6 +53,6 @@ public IRecordDAO newRecordDao(StorageBuilder<Record>
storageBuilder) {
@Override
public INoneStreamDAO newNoneStreamDao(StorageBuilder<NoneStream>
storageBuilder) {
- return new NoneStreamDAO();
+ return new NoneStreamDAO(influxClient, storageBuilder);
Review comment:
`INoneStreamDAO` is used for web interactive job, such as @mrproliu 's
profiling task. Basically, this should have little data. Is the influxDB
suitable for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
