wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230959
########## File path: oap-server/server-bootstrap/src/main/resources/official_analysis.oal ########## @@ -102,3 +102,77 @@ envoy_parent_connections_used = from(EnvoyInstanceMetric.value).filter(metricNam // disable(top_n_database_statement); // disable(zipkin_span); // disable(jaeger_span); + + +// Browser metrics begin Review comment: @kezhenxu94 I want to discuss a thing with you. In @arugal prev PR, this part of OAL is separated in another OAL, I asked him to change like this. But in these days, I prefer his way more. If those are in another OAL file, then OAL engine could provide an API to activate some OAL files, such as from browser-receiver provider. This should make our document easier. What do you think? @arugal ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
