kezhenxu94 commented on a change in pull request #4228: Support Browser 
protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r368289849
 
 

 ##########
 File path: oap-server/server-bootstrap/src/main/resources/official_analysis.oal
 ##########
 @@ -102,3 +102,77 @@ envoy_parent_connections_used = 
from(EnvoyInstanceMetric.value).filter(metricNam
 // disable(top_n_database_statement);
 // disable(zipkin_span);
 // disable(jaeger_span);
+
+
+// Browser metrics begin
 
 Review comment:
   > Actually, I don't want to separate too many files. It was this PR, there 
were two OAL files, one for backend service, the other for browser. They are 
activated by receiver. What do you think?
   
   Anyway, I'm with this idea, it doesn't matter for me how many OAL files are 
divided into, finally :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to