arugal commented on a change in pull request #4228: Support Browser protocol at 
OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r368352870
 
 

 ##########
 File path: oap-server/server-bootstrap/src/main/resources/official_analysis.oal
 ##########
 @@ -102,3 +102,77 @@ envoy_parent_connections_used = 
from(EnvoyInstanceMetric.value).filter(metricNam
 // disable(top_n_database_statement);
 // disable(zipkin_span);
 // disable(jaeger_span);
+
+
+// Browser metrics begin
 
 Review comment:
   > And activate the OAL by the receiver? 
   
   Agree.
   
   ### Design
   1.  `official_analysis.oal` and `browser_analysis.oal`
   1. `official_analysis.oal` activate by `mission-metric, istio-telemetry, 
service-mesh, receiver-trace, receiver-so11y, receiver-jvm, receiver-clr `
   1. `browser_analysis.oal` activate by `browser-receiver`
   1.  each file will only be activated once
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to