[GitHub] [skywalking-swck] arugal commented on pull request #5: Update README.md

[GitBox]

arugal commented on pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#issuecomment-723519207


   > > > We can set namespace by `cd config/default && kustomize edit set 
namespace <new ns>` or just edit `config/default/kustomization.yaml`. And I 
mentioned how to customize it in 
https://github.com/apache/skywalking-swck/pull/5/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R34.
   > > 
   > > 
   > > The [namespace 
parameter](https://github.com/apache/skywalking-swck/blob/893474a5e4bc10da4bdcb26855d373b61967f69b/config/default/kustomization.yaml#L19)
 is not valid for [namespace 
resource](https://github.com/apache/skywalking-swck/blob/893474a5e4bc10da4bdcb26855d373b61967f69b/config/manager/manager.yaml#L18-L23).
   > > I think that's the way it should be.
   > > ```yaml
   > > apiVersion: v1
   > > kind: Namespace
   > > metadata:
   > >   labels:
   > >     control-plane: controller-manager
   > >   name: skywalking-swck-system
   > > ```
   > 
   > My local kustomize could generate correct namespace:
   > 
   > ```shell
   >  $ kustomize version
   > {Version:3.5.4 GitCommit:3af514fa9f85430f0c1557c4a0291e62112ab026 
BuildDate:2020-01-17T14:23:25+00:00 GoOs:darwin GoArch:amd64}
   >  $ kustomize build config/default
   > apiVersion: v1
   > kind: Namespace
   > metadata:
   >   labels:
   >     control-plane: controller-manager
   >   name: skywalking-swck-system
   > ```
   > 
   > I'm curious about which version your kusomize is?
   > 
   > and my kubectl also could get the same result:
   > 
   > ```
   > $ kubectl version --client
   > Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.1", 
GitCommit:"7879fc12a63337efff607952a323df90cdc7a335", GitTreeState:"clean", 
BuildDate:"2020-04-10T21:53:51Z", GoVersion:"go1.14.2", Compiler:"gc", 
Platform:"darwin/amd64"}
   >  $ kubectl kustomize config/default 
   > apiVersion: v1
   > kind: Namespace
   > metadata:
   >   labels:
   >     control-plane: controller-manager
   >   name: skywalking-swck-system
   > ---
   > ```
   
   @hanahmily Sorry, I have tested kustomize 3.8.1-3.8.4 locally and this seems 
to be the case only at 3.8.2.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org