[GitHub] [skywalking-swck] arugal commented on a change in pull request #5: Update README.md

[GitBox]

arugal commented on a change in pull request #5:
URL: https://github.com/apache/skywalking-swck/pull/5#discussion_r519244934



##########
File path: controllers/oapserver_controller.go
##########
@@ -52,6 +52,7 @@ type OAPServerReconciler struct {
 // 
+kubebuilder:rbac:groups=operator.skywalking.apache.org,resources=oapservers,verbs=get;list;watch;create;update;patch;delete
 // 
+kubebuilder:rbac:groups=operator.skywalking.apache.org,resources=oapservers/status,verbs=get;update;patch
 // 
+kubebuilder:rbac:groups=apps,resources=deployments,verbs=get;list;watch;create;update;patch;delete
+// 
+kubebuilder:rbac:groups=,resources=services,verbs=get;list;watch;create;update;patch;delete

Review comment:
       ```suggestion
   // 
+kubebuilder:rbac:groups="",resources=services,verbs=get;list;watch;create;update;patch;delete
   ```
   
    Need to specify group.
   ```
   The ClusterRole "skywalking-swck-manager-role" is invalid: 
rules[0].apiGroups: Required value: resource rules must supply at least one api 
group
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org