etr2460 commented on a change in pull request #15909:
URL: https://github.com/apache/superset/pull/15909#discussion_r679475543
##########
File path: superset/connectors/sqla/models.py
##########
@@ -1669,6 +1677,47 @@ class and any keys added via `ExtraCache`.
extra_cache_keys += sqla_query.extra_cache_keys
return extra_cache_keys
+ @staticmethod
+ def before_update(
+ mapper: Mapper, # pylint: disable=unused-argument
+ connection: Connection, # pylint: disable=unused-argument
+ target: "SqlaTable",
+ ) -> None:
+ """
+ Check whether before update if the target table already exists.
+
+ Note this listener is called when any fields are being updated and
thus it is
+ necessary to first check whether the reference table is being updated.
+
+ Note this logic is temporary, given uniqueness is handled via the
dataset DAO,
+ but is necessary until both the legacy datasource editor and
datasource/save
+ endpoints are deprecated.
+
+ :param mapper: The table mapper
+ :param connection: The DB-API connection
+ :param target: The mapped instance being persisted
+ :raises Exception: If the target table is not unique
+ """
+
+ from superset.datasets.commands.exceptions import
get_dataset_exist_error_msg
+ from superset.datasets.dao import DatasetDAO
+
+ # Check whether the relevant attributes have changed.
+ state = db.inspect(target) # pylint: disable=no-member
+
+ for attr in ["database_id", "schema", "table_name"]:
+ history = state.get_history(attr, True)
+
+ if history.has_changes():
+ break
+ else:
+ return None
Review comment:
is this intentional? indentation seems rather odd here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
