etr2460 commented on a change in pull request #15909:
URL: https://github.com/apache/superset/pull/15909#discussion_r679474958
##########
File path: superset/connectors/sqla/models.py
##########
@@ -487,7 +487,15 @@ class SqlaTable( # pylint:
disable=too-many-public-methods,too-many-instance-at
owner_class = security_manager.user_model
__tablename__ = "tables"
- __table_args__ = (UniqueConstraint("database_id", "table_name"),)
+
+ # Note this uniqueness constraint is not part of the physical schema,
i.e., it does
+ # not exist in the migrations, but is required by `import_from_dict` to
ensure the
+ # correct filters are applied in order to identify uniqueness.
+ #
+ # The reason it does not physically exist is MySQL, PostgreSQL have a
different
Review comment:
grammar nit: `...is MySQL and PostgreSQL`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
