villebro commented on a change in pull request #18192:
URL: https://github.com/apache/superset/pull/18192#discussion_r794266542
##########
File path:
superset-frontend/cypress-base/cypress/integration/explore/visualizations/line.test.ts
##########
@@ -19,7 +19,11 @@
import { FORM_DATA_DEFAULTS, NUM_METRIC, SIMPLE_FILTER } from
'./shared.helper';
describe('Visualization > Line', () => {
- const LINE_CHART_DEFAULTS = { ...FORM_DATA_DEFAULTS, viz_type: 'line' };
+ const LINE_CHART_DEFAULTS = {
+ ...FORM_DATA_DEFAULTS,
+ viz_type: 'line',
+ show_legend: true,
Review comment:
Before, the "Legend" checkbox would be unchecked, but the legend would
still display due to the control value being `undefined`:
After this, the legend isn't displayed as the control value is properly set
to the default value (`false`):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
