villebro commented on a change in pull request #18192:
URL: https://github.com/apache/superset/pull/18192#discussion_r793898844
##########
File path:
superset-frontend/cypress-base/cypress/integration/explore/visualizations/line.test.ts
##########
@@ -19,7 +19,11 @@
import { FORM_DATA_DEFAULTS, NUM_METRIC, SIMPLE_FILTER } from
'./shared.helper';
describe('Visualization > Line', () => {
- const LINE_CHART_DEFAULTS = { ...FORM_DATA_DEFAULTS, viz_type: 'line' };
+ const LINE_CHART_DEFAULTS = {
+ ...FORM_DATA_DEFAULTS,
+ viz_type: 'line',
+ show_legend: true,
Review comment:
Legends were disabled by default in
https://github.com/apache-superset/superset-ui/pull/904, but unfortunately the
`false` aka falsy default value still caused the legend to be rendered (I
assume `undefined` reverts to the default legend rendering prop in NVD3 which
is `true`). This updates the test to explicitly enable the legend to ensure
that the `nv-legend-text` class is found in the assertions below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
