zhaoyongjie commented on a change in pull request #18576:
URL: https://github.com/apache/superset/pull/18576#discussion_r801341601
##########
File path: superset/key_value/api.py
##########
@@ -122,9 +113,7 @@ def put(self, pk: int, key: str) -> Response:
def get(self, pk: int, key: str) -> Response:
try:
- args = CommandParameters(
- actor=g.user, resource_id=pk, key=key,
query_params=request.args
- )
+ args = CommandParameters(actor=g.user, resource_id=pk, key=key)
value = self.get_get_command()(args).run()
if not value:
Review comment:
What happens if the cache temporarily unavailable? we should set cache
if cache broke down and load form_data from database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
