michael-s-molina commented on a change in pull request #18576:
URL: https://github.com/apache/superset/pull/18576#discussion_r802630815
##########
File path: superset/explore/form_data/commands/create.py
##########
@@ -40,7 +41,10 @@ def run(self) -> str:
actor = self._cmd_params.actor
form_data = self._cmd_params.form_data
check_access(dataset_id, chart_id, actor)
- key = token_urlsafe(48)
+ contextual_key = cache_key(actor.get_user_id(), dataset_id,
chart_id)
Review comment:
1. Great call on the different sessions approach! I modified the code to
follow your suggestion.
2. I think we don't need the extra overhead of a hashing function. The
concatenation is just fine for this use case. Even if we would apply a hashing
function we would still need to concatenate the arguments. I left this
untouched. Let me know if you disagree 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
