hughhhh commented on a change in pull request #18953:
URL: https://github.com/apache/superset/pull/18953#discussion_r816355012
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseList.tsx
##########
@@ -171,8 +182,43 @@ function DatabaseList({ addDangerToast, addSuccessToast }:
DatabaseListProps) {
const canExport =
hasPerm('can_export') && isFeatureEnabled(FeatureFlag.VERSIONED_EXPORT);
+ const uploadDropdownMenu = [
+ {
+ label: t('Upload file to database'),
+ childs: [
+ {
+ label: t('Upload a CSV'),
+ name: 'Upload a CSV',
+ url: '/csvtodatabaseview/form',
+ perm: CSV_EXTENSIONS,
+ },
+ {
+ label: t('Upload a Columnar File'),
+ name: 'Upload a Columnar file',
+ url: '/columnartodatabaseview/form',
+ perm: COLUMNAR_EXTENSIONS,
+ },
+ {
+ label: t('Upload Excel'),
+ name: 'Upload Excel',
+ url: '/exceltodatabaseview/form',
+ perm: EXCEL_EXTENSIONS,
+ },
+ ],
+ },
+ ];
+
+ const filteredDropDown = uploadDropdownMenu.map(link => {
+ // eslint-disable-next-line no-param-reassign
+ link.childs = link.childs.filter(item =>
+ checkUploadExtensions(item.perm, ALLOWED_EXTENSIONS),
+ );
+ return link;
Review comment:
nit: make a new object and return links:
```
const { childs } = link
return [...childs.filter(item =>
checkUploadExtensions(item.perm, ALLOWED_EXTENSIONS),
)];
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
