yousoph commented on pull request #18953: URL: https://github.com/apache/superset/pull/18953#issuecomment-1058603927
@pkdotson Some notes / change requests: 1. Dropdown text is the wrong color - it should be the same as primary button for both default and hover states. (Caret color is correct though so that doesn't need to change) 2. The dropdown and the + Database button aren't vertically centered in the header bar. Same issue on the other CRUD pages 3. Dropdown menu should open on click rather than on hover 4. The down caret next to the "Upload file to database" text doesn't look vertically centered - it looks too low 5. Text updates : remove "a" before CSV and Columnar File 6. Casing update: Should be "Upload a columnar file" 7. There's something happening with the animation when the dropdown opens that makes it look like it's flashing a bit. There's a blue line that shows for a second 8. The dropdown alignment looks too high and too close to the text - check the [Figma file](https://www.figma.com/file/ZGRrjGFNGHYxlsqOQy7pz3/Data-Connection-Enhancements?node-id=4%3A4428) for reference -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
