michael-s-molina commented on a change in pull request #19049:
URL: https://github.com/apache/superset/pull/19049#discussion_r822955990



##########
File path: UPDATING.md
##########
@@ -27,7 +27,7 @@ assists people when migrating to a new version.
 - [18936](https://github.com/apache/superset/pull/18936): Removes legacy 
SIP-15 interm logic/flags—specifically the `SIP_15_ENABLED`, 
`SIP_15_GRACE_PERIOD_END`, `SIP_15_DEFAULT_TIME_RANGE_ENDPOINTS`, and 
`SIP_15_TOAST_MESSAGE` flags. Time range endpoints are no longer configurable 
and strictly adhere to the `[start, end)` paradigm, i.e., inclusive of the 
start and exclusive of the end. Additionally this change removes the now 
obsolete `time_range_endpoints` from the form-data and resulting in the cache 
being busted.
 
 ### Breaking Changes
-
+- [19049](https://github.com/apache/superset/pull/19049): APP_ICON_WIDTH has 
been removed from the config. Superset should now be able to handle different 
logo sizes without having to explicitly set a APP_ICON_WIDTH. This might affect 
the size of existing custom logos as the UI will now resize them according to 
the specified space of maximum 148px and not according to the value of 
APP_ICON_WIDTH.

Review comment:
       ```suggestion
   - [19049](https://github.com/apache/superset/pull/19049): APP_ICON_WIDTH has 
been removed from the config. Superset should now be able to handle different 
logo sizes without having to explicitly set an APP_ICON_WIDTH. This might 
affect the size of existing custom logos as the UI will now resize them 
according to the specified space of maximum 148px and not according to the 
value of APP_ICON_WIDTH.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to