rusackas commented on a change in pull request #19049:
URL: https://github.com/apache/superset/pull/19049#discussion_r824227008
##########
File path: superset-frontend/src/views/components/Menu.tsx
##########
@@ -97,6 +96,17 @@ const StyledHeader = styled.header`
display: flex;
flex-direction: column;
justify-content: center;
+ min-height: ${({ theme }) => `${theme.gridUnit * 12.5}px`};
Review comment:
Maybe we just forgo the gridUnit here and give it a pixel measurement
(and maybe a comment for the rationale). Then it won't be fragile if someone
changes the gridUnit from 4px to 5px in their theme.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
