villebro commented on a change in pull request #19078:
URL: https://github.com/apache/superset/pull/19078#discussion_r824610678
##########
File path: superset-frontend/src/dashboard/containers/DashboardPage.tsx
##########
@@ -161,12 +164,18 @@ const DashboardPage: FC = () => {
useEffect(() => {
// eslint-disable-next-line consistent-return
async function getDataMaskApplied() {
+ const permalinkStateKey = getUrlParam(URL_PARAMS.permalinkStateKey);
const nativeFilterKeyValue = getUrlParam(URL_PARAMS.nativeFiltersKey);
let dataMaskFromUrl = nativeFilterKeyValue || {};
const isOldRison = getUrlParam(URL_PARAMS.nativeFilters);
- // check if key from key_value api and get datamask
- if (nativeFilterKeyValue) {
+ // check if key from temporary_cache api and get datamask
Review comment:
Removing, as the functions are pretty self explanatory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
