villebro commented on a change in pull request #19078:
URL: https://github.com/apache/superset/pull/19078#discussion_r824612110
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
##########
@@ -200,7 +205,9 @@ const publishDataMask = debounce(
} else {
dataMaskKey = await createFilterKey(dashboardId, dataMask, tabId);
}
- newParams.set(URL_PARAMS.nativeFiltersKey.name, dataMaskKey);
+ if (dataMaskKey) {
Review comment:
If I understand this correctly, when navigating to the dashboard without
a native filter key, this will be undefined (this is later populated when the
current state is cached)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
