betodealmeida commented on a change in pull request #19314:
URL: https://github.com/apache/superset/pull/19314#discussion_r838851280
##########
File path:
superset-frontend/src/views/CRUD/data/database/DatabaseModal/ModalHeader.tsx
##########
@@ -142,19 +154,23 @@ const ModalHeader = ({
</StyledFormHeader>
);
+ const importDbHeader = (
+ <StyledStickyHeader>
+ <StyledFormHeader>
+ <p className="helper-top"> STEP 2 OF 2 </p>
+ <h4>Enter the required {dbModel.name} credentials</h4>
+ <p className="helper-bottom">{fileCheck ? file[0].name : ''}</p>
+ </StyledFormHeader>
+ </StyledStickyHeader>
+ );
+
+ if (fileCheck) return importDbHeader;
if (isLoading) return <></>;
- if (isEditMode) {
- return isEditHeader;
- }
- if (useSqlAlchemyForm) {
- return useSqlAlchemyFormHeader;
- }
- if (hasConnectedDb && !editNewDb) {
- return hasConnectedDbHeader;
- }
- if (db || editNewDb) {
- return hasDbHeader;
- }
+ if (isEditMode) return isEditHeader;
+ if (useSqlAlchemyForm) return useSqlAlchemyFormHeader;
+ if (hasConnectedDb && !editNewDb) return hasConnectedDbHeader;
+ if (db || editNewDb) return hasDbHeader;
Review comment:
We could also use a switch here:
```js
switch (true) {
case fileCheck: return importDbHeader;
case isLoading: return <></>;
case isEditMode: return isEditHeader;
case useSqlAlchemyForm: return useSqlAlchemyFormHeader;
case hasConnectedDb && !editNewDb: return hasConnectedDbHeader;
case db || editNewDb: return hasDbHeader;
default: noDbHeader;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
