lyndsiWilliams commented on a change in pull request #19314:
URL: https://github.com/apache/superset/pull/19314#discussion_r839028850
##########
File path:
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -814,6 +858,25 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps>
= ({
</>
);
}
+
+ // Import doesn't use db, so footer will not render in the if statement
above
Review comment:
Yeah that's what I meant, it doesn't use db state. I clarified that in
[`this
commit`](https://github.com/apache/superset/pull/19314/commits/f1a7e8bab5e67b2a60da331745001914c1ef8e53)
- do you think that's good or should I clarify further?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
