diegomedina248 commented on code in PR #20395:
URL: https://github.com/apache/superset/pull/20395#discussion_r898184957
##########
superset/db_engine_specs/base.py:
##########
@@ -913,19 +920,24 @@ def extract_errors(
if match:
params = {**context, **match.groupdict()}
extra["engine_name"] = cls.engine_name
+ message, more_message = cls._reformat_error_message(message %
params)
Review Comment:
Do we know in how many places this error is returned?
I'm concerned we miss one in the FE and start showing less information than
before.
We could, if not, keep the message property the same, and add a new one with
the changes here.
Thoughts?
cc: @rusackas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
