mistercrunch commented on code in PR #20395:
URL: https://github.com/apache/superset/pull/20395#discussion_r900316041
##########
superset/db_engine_specs/base.py:
##########
@@ -913,19 +920,24 @@ def extract_errors(
if match:
params = {**context, **match.groupdict()}
extra["engine_name"] = cls.engine_name
+ message, more_message = cls._reformat_error_message(message %
params)
Review Comment:
`more_message` is not a great name, and shuffling tuples around is funky.
Let's create a proper simple object (probably namedtuple or dataclass) for this
with good names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
