codyml opened a new pull request, #20528: URL: https://github.com/apache/superset/pull/20528
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR adds thumbnails to the sidebar of draggable charts in the edit dashboard view. Thumbnails are shown when the `THUMBNAILS` feature flag is enabled. If no thumbnail has been generated, the same placeholder that's used on the chart list card view is shown. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> **Before:**  **After:**  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Run Superset with `THUMBNAILS=False` and ensure that there are no changes to the Charts tab of the left pane of the dashboard editor. 2. Run Superset with `THUMBNAILS=True` and ensure that thumbnails appear (or at least that their placeholders do). I'm not sure how to force thumbnail generation locally so I'm not sure how to make sure the actual thumbnails replace the placeholders when they exist, but I'm hoping it'll work as I copied the logic almost exactly from how the chart list card thumbnails are rendered. From the contributing documentation, it looks like `/testenv up FEATURE_THUMBNAILS=true` should create an instance with the feature flag set, and maybe that instance will generate thumbnails automatically at some point? Any advice appreciated. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [x] Required feature flags: `THUMBNAILS` - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
