zhaoyongjie commented on code in PR #20528:
URL: https://github.com/apache/superset/pull/20528#discussion_r909338769
##########
superset-frontend/src/dashboard/components/AddSliceCard/index.jsx:
##########
@@ -111,14 +132,31 @@ function AddSliceCard({
lastModified,
sliceName,
style,
+ thumbnailUrl,
visType,
}) {
+ const showThumbnails = useMemo(
+ () => isFeatureEnabled(FeatureFlag.THUMBNAILS),
+ [],
+ );
+
Review Comment:
the value of `isFeatureEnabled(FeatureFlag.THUMBNAILS)` will not change when
the Superset web application started, so the `useMemo` might be useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
