ktmud opened a new pull request, #20632: URL: https://github.com/apache/superset/pull/20632
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Make dashboard permalink API always return the same key if the request payload is the same---i.e., for a given dashboard state, a user should always get a stable permalink when they request one. This is a required change for #20552 and #19354 as we don't want to generate a new permalink each time a dashboard report is executed. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A. This is a pure backend change. There should be no visible changes to users. ### TESTING INSTRUCTIONS 1. Copy a permalink for dashboard---you can do it in the "..." menu on the dashboard page, or in charts or tabs. <img width="575" alt="image" src="https://user-images.githubusercontent.com/335541/177657369-ffa725fa-fed4-4328-9877-4edc9a314b8b.png";> 3. The link should always be the same no matter how many times you click on the trigger button/link ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/335541/177657369-ffa725fa-fed4-4328-9877-4edc9a314b8b.png"](https://user-images.githubusercontent.com/335541/177657369-ffa725fa-fed4-4328-9877-4edc9a314b8b.png"){kind=link}