ktmud commented on code in PR #20632:
URL: https://github.com/apache/superset/pull/20632#discussion_r916448055
##########
superset/dashboards/permalink/commands/create.py:
##########
@@ -40,21 +53,28 @@ def __init__(
self.dashboard_id = dashboard_id
self.state = state
+ @property
+ def value(self) -> DashboardPermalinkValue:
+ return {
+ "dashboardId": self.dashboard_id,
+ "state": self.state,
+ }
+
+ @property
+ def signature(self) -> Tuple[Optional[int], DashboardPermalinkValue]:
Review Comment:
Just thought it'd be safer to give each user a unique permalink in case we
want to anything special about it. (Can't think of a use case just yet) Plus
user id is also saved for KeyValue so you can also argue this is for
completeness sake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
