michael-s-molina commented on code in PR #20645:
URL: https://github.com/apache/superset/pull/20645#discussion_r916855923


##########
superset-frontend/packages/superset-ui-chart-controls/src/types.ts:
##########
@@ -66,6 +67,7 @@ export interface Dataset {
   id: number;
   type: DatasourceType;
   columns: ColumnMeta[];
+  column_types?: GenericDataType[];

Review Comment:
   I had to revert the change because columns and column_types don't match. I 
investigated but wasn't able to find the root cause. I believe merging these 
will require its own PR and tests so I'll leave it out of this PR. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to