michael-s-molina commented on code in PR #20645:
URL: https://github.com/apache/superset/pull/20645#discussion_r916858504


##########
superset-frontend/packages/superset-ui-chart-controls/src/types.ts:
##########
@@ -66,6 +67,7 @@ export interface Dataset {
   id: number;
   type: DatasourceType;
   columns: ColumnMeta[];
+  column_types?: GenericDataType[];

Review Comment:
   Running E2E tests, I found a case where the `columns` were all strings but 
`column_types` contained 0, 1, 2 (numeric, string, temporal)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to