eschutho commented on code in PR #20281:
URL: https://github.com/apache/superset/pull/20281#discussion_r917036853
##########
superset-frontend/packages/superset-ui-core/src/query/types/Datasource.ts:
##########
@@ -47,11 +47,17 @@ export interface Datasource {
};
}
-export const DEFAULT_METRICS = [
+export const DEFAULT_METRICS: Metric[] = [
{
metric_name: 'COUNT(*)',
expression: 'COUNT(*)',
},
];
+export const isValidDatasourceType = (datasource: DatasourceType) =>
+ datasource === DatasourceType.Dataset ||
Review Comment:
can we do something like `datasource in DatasourceType` or do we need to
list out all of the types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
