eschutho commented on code in PR #20281:
URL: https://github.com/apache/superset/pull/20281#discussion_r917042860
##########
superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx:
##########
@@ -148,10 +172,10 @@ export const SaveDatasetModal:
FunctionComponent<SaveDatasetModalProps> = ({
const handleOverwriteDataset = async () => {
const [, key] = await Promise.all([
updateDataset(
- query.dbId,
+ datasource.dbId,
datasetToOverwrite.datasetid,
- query.sql,
- query.results.selected_columns.map(
+ datasource.sql,
+ datasource?.columns?.map(
Review Comment:
we have some datasources that seem optional here (via the optional chaining)
and some that aren't. Is that intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
