codyml commented on code in PR #20891:
URL: https://github.com/apache/superset/pull/20891#discussion_r940605838
##########
superset-frontend/src/components/Chart/ChartRenderer.jsx:
##########
@@ -172,6 +196,22 @@ class ChartRenderer extends React.Component {
}
}
+ handleOnContextMenu(filters, offsetX, offsetY) {
+ this.contextMenuRef.current.open(filters, offsetX, offsetY);
+ this.setState({ inContextMenu: true });
+ }
+
+ handleContextMenuSelected(filters) {
+ const extraFilters = this.props.formData.extra_form_data.filters || [];
Review Comment:
I'm getting an error on this line when I try to select "Drill by x": `Cannot
read properties of undefined (reading 'filters')`. I think it might be because
I'm running it with `DRILL_TO_DETAIL` only and not `DASHBOARD_CROSS_FILTERS`,
and it seems like the `extra_form_data` isn't initialized as an empty object
when `DASHBOARD_CROSS_FILTERS` isn't enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
