codyml commented on code in PR #20891:
URL: https://github.com/apache/superset/pull/20891#discussion_r940616664
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx:
##########
@@ -159,13 +165,25 @@ class BigNumberVis extends
React.PureComponent<BigNumberVisProps> {
});
container.remove();
+ const onContextMenu = (e: MouseEvent<HTMLDivElement>) => {
+ if (this.props.onContextMenu) {
+ e.preventDefault();
+ this.props.onContextMenu(
+ [],
Review Comment:
For this one, even though you can't drill to detail based on the trendline
because the timestamp is not a dimension (I'm assuming?), it was a little
confusing for me to not be able to right-click on the trendline at all. What
would you think about adding a plain "Drill to detail" menu option that doesn't
add any filters when you right-click on the trendline?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
